"Narrow cast" total execution time when checking against the deadline

webatintel / aquarium

BSD 3-Clause "New" or "Revised" License

26 stars 7 forks source link

"Narrow cast" total execution time when checking against the deadline #193

Closed hujiajie closed 3 years ago

hujiajie commented 3 years ago

This saves the need for the AUTOSTOP toggle, with no perceptible behavior change in 99.9% cases:

If --test-time is not given, then it defaults to INT_MAX, so the test always fails and Aquarium will keep running forever.
If --test-time is given but the user-specified value is far less than INT_MAX seconds (≈ 68 years), Aquarium should quit automatically as it used to do.

hujiajie commented 3 years ago

The real motivation is that there isn't an elegant way to tell if a flag is manually specified or not when using the Abseil flags library, so the AUTOSTOP toggle cannot be properly set like before.