search

webaudiomodules / webdx7

virtual Yamaha DX7 synth
https://webaudiomodules.org/wamsynths/dx7
MIT License
139 stars 24 forks source link

Fixes for CC <> `Controllers` implementation and initialization #10

Closed micahscopes closed 2 years ago

micahscopes commented 3 years ago

I noticed that after upgrading to the latest Dexed MSFA changes, some of my flute patches weren't working.

It turned out that these patches relied on some cc controller mappings that weren't getting properly initialized.

Dexed's MSFA code doesn't even have synth_unit.cc anymore, instead using some separate GPL licensed code to do what synth_unit.cc used to do.

But webdx7 still needs synth_unit.cc, so this PR ensures that it properly initializes cc values, and also ensures that MIDI cc events are handled correctly.

For the record, synth_unit.cc is the only file with any significant difference from the Dexed MSFA code. I've kept all of the other files more or less unchanged.

jariseon commented 2 years ago

thanks again micahscopes, excellent work.