Closed HSMDBC closed 2 years ago
Can you tell me why this pull request lists the "old" commits that were already merged by the previous pull request?
Not sure, but the simplest way to get a clean PR is to sync "your" master with webauthn-open-source/fido2-lib, create a new branch (per PR) and work in that branch. Never commit to master, just keep it in sync with webauthn-open-source/fido2-lib, and use that as a base for your feature branches.
@Hexagon thanks, i will give it a try next time. (btw, I've synced the master. But it really doesn't seem like a good idea to commit directly to the master)
Merging #108 (d938d5a) into master (f6d237d) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 92.90% 92.93% +0.02%
==========================================
Files 16 16
Lines 5963 5986 +23
==========================================
+ Hits 5540 5563 +23
Misses 423 423
Impacted Files | Coverage Δ | |
---|---|---|
lib/response.js | 97.56% <100.00%> (+0.01%) |
:arrow_up: |
lib/validator.js | 92.29% <100.00%> (+0.23%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Try having a look at why coverage is decreasing, and bump version to 3.3.2. Other than that it looks great 👍
@JamesCullum can you check that please?
LGTM, original post by Codecov is updated with a positive result.
Thanks a lot for the great PR, quick fix, good test coverage
Hexagon already reviewed and merged - thanks!
Fixed error: "internal audit failed: webAuthnExtensions was not validated"
Added missing validator for auditing extension.