search

webauthn-open-source / fido2-lib

A node.js library for performing FIDO 2.0 / WebAuthn server functionality
https://webauthn.io
MIT License
394 stars 118 forks source link

JSDOC 3 deprecation #126

Closed JamesCullum closed 1 year ago

JamesCullum commented 1 year ago

If someone has experience with JSDOC 3 to 4 migrations - we are currently using v3, which is deprecated and has a vulnerable (dev)Dependency, and would highly appreciate having someone experienced migrate it to v4.

Hexagon commented 1 year ago

It should just be a matter of changing version number to ~4.0.0, npm i, and rebuild docs. 👍

Can not remember I had any issues upgrading my own packages.

https://github.com/jsdoc/jsdoc/blob/main/CHANGES.md

JamesCullum commented 1 year ago

I created the issue after trying this and receiving dozen of errors - so its sadly not THAT easy

Hexagon commented 1 year ago

Oh. I can have a look at it then 👍

Hexagon commented 1 year ago

@JamesCullum about the problem at release, change deno -version from 1.20.1 to 1.x just like the test pipeline

JamesCullum commented 1 year ago

Thanks, done and works 👍