search

webauthn-open-source / fido2-lib

A node.js library for performing FIDO 2.0 / WebAuthn server functionality
https://webauthn.io
MIT License
407 stars 120 forks source link

Missing MDS types #136

Open gaizeror opened 1 year ago

gaizeror commented 1 year ago

Hey,

I tried to use MDS classes in my typescript project and found out that the types of MDS classes and the static functions in Fido2Lib class are not exported. Is there a reason for it? is there a types lib can be installed? I don't mind creating a PR with the missing interfaces, but I think it should either be a requirement for new features or excluded from the project, the partial types is annoying

example: image image

Thanks

JamesCullum commented 1 year ago

Thanks for the great suggestion. The library isn't primarily focusing on typescript (as it's been born in a time before , but tries to allow integration with those projects with syntax highlighting.

Generally we're favoring compatibility and features over typescript conformity, so I wouldn't be in favor of blocking good code requests without it.

If we can improve the typescript types without adding other issues, PRs etc are always welcome and we can try to ask contributors to extend the interface accordingly.