codecov-commenter
commented
1 year ago Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.
Comparison is base (
e4fd8a0) 92.97% compared to head (c81e381) 92.85%.:exclamation: Current head c81e381 differs from pull request most recent head e033fa4. Consider uploading reports for the commit e033fa4 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #138 +/- ## ========================================== - Coverage 92.97% 92.85% -0.12% ========================================== Files 16 16 Lines 6007 6019 +12 ========================================== + Hits 5585 5589 +4 - Misses 422 430 +8 ``` | [Files](https://app.codecov.io/gh/webauthn-open-source/fido2-lib/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webauthn-open-source) | Coverage Δ | | |---|---|---| | [lib/certUtils.js](https://app.codecov.io/gh/webauthn-open-source/fido2-lib/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webauthn-open-source#diff-bGliL2NlcnRVdGlscy5qcw==) | `89.56% <80.00%> (-1.20%)` | :arrow_down: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
JamesCullum
Hi there, I know this is a pretty old issue so I figured I'd take it up. This is my first contribution to an open source library. :-)
I've added fixes for the getIssuer and getSerial functions in certUtils as requested in https://github.com/webauthn-open-source/fido2-lib/issues/15. It'll no longer be necessary to index directly into
typesAndValues. Please let me know if there's anything else that I'm missing!