search

webauthn-open-source / fido2-lib

A node.js library for performing FIDO 2.0 / WebAuthn server functionality
https://webauthn.io
MIT License
394 stars 118 forks source link

Fix new certificates #151

Closed popeeyy closed 6 months ago

popeeyy commented 7 months ago

Fix the parsing of new certificates from TruU and OneSpan (found in https://mds.fidoalliance.org) Fixes issue https://github.com/webauthn-open-source/fido2-lib/issues/144

JamesCullum commented 6 months ago

Thanks a lot for the debugging and PR!

Can you remove the package-lock from commit and bump the version in package.json to 3.4.4?

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (50ee8da) 92.85% compared to head (f6ffa95) 92.86%. Report is 1 commits behind head on master.

:exclamation: Current head f6ffa95 differs from pull request most recent head 193edd0. Consider uploading reports for the commit 193edd0 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #151 +/- ## ======================================= Coverage 92.85% 92.86% ======================================= Files 16 16 Lines 6019 6023 +4 ======================================= + Hits 5589 5593 +4 Misses 430 430 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JamesCullum commented 6 months ago

Can you add a test case for the certificate that only works for your case? This would maintain the code coverage and make sure that future changes don't destroy it!

Then we are good to merge, thanks a lot for your help!