Regression with 3.5.1: Error: Cannot find module 'punycode.js' - Githubissues

webauthn-open-source / fido2-lib

A node.js library for performing FIDO 2.0 / WebAuthn server functionality

https://webauthn.io

MIT License

394 stars 118 forks source link

Regression with 3.5.1: Error: Cannot find module 'punycode.js' #164

Closed pozylon closed 4 months ago

pozylon commented 4 months ago

Require stack:

/Users/xxx/Repositories/lorem/engine/node_modules/fido2-lib/dist/main.cjs at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15) at Module._load (node:internal/modules/cjs/loader:985:27) at Module.require (node:internal/modules/cjs/loader:1235:19) at require (node:internal/modules/helpers:176:18)

highvoltz commented 4 months ago

I am getting the same error. Removing the .js from var punycode = require('punycode.js'); in main.cjs fixes it.

Hexagon commented 4 months ago

Oh, that's my fault, and that's correct. Punycode.js should be moved to regular dependencies. I cant fix right now, so its open for a pull request. If anyone is up for the task - bump the version one revision too.

Hexagon commented 4 months ago

Hopefully fixed in #165

JamesCullum commented 4 months ago

Should be fixed in 3.5.3 now