search

webauthn-open-source / fido2-lib

A node.js library for performing FIDO 2.0 / WebAuthn server functionality
https://webauthn.io
MIT License
407 stars 120 forks source link

Fixes #69 #94

Closed Hexagon closed 2 years ago

Hexagon commented 2 years ago

No exposed code has changed, no release needed

codecov-commenter commented 2 years ago

Codecov Report

Merging #94 (99ad0e4) into master (cb93367) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 99ad0e4 differs from pull request most recent head c2e64be. Consider uploading reports for the commit c2e64be to get more accurate results

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          15       15           
  Lines        5818     5818           
=======================================
  Hits         5407     5407           
  Misses        411      411

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5003fa...c2e64be. Read the comment docs.

Hexagon commented 2 years ago

@JamesCullum Could merge this mysellf, but i'm not sure if it's possible to merge without bumping (because of ci)?

JamesCullum commented 2 years ago

Sure, you can merge without bumping the version - it just wont create a new release, so it cannot be used by Deno or NodeJS users. In this case its only a test and it passes, so you can feel free to merge yourself. Or I can do it for you, let me know what you prefer 👍