Closed gonnavis closed 1 year ago
vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| character-creator | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Jan 21, 2023 at 8:38PM (UTC) |
gonnavis
commented
1 year ago Looks pretty good to me :) , just a small coment would be that when it finishes the process, the character stays with the mesh unculled until we select another trait: example:
Maybe an update cull right after the export process :) ?
In order to follow the previous "new mesh/geometry" logic pattern, and prevent fails when exporting block the later restoring, I chose to clone geometry instead of modify/restore original geometry.
Fix https://github.com/webaverse-studios/CharacterCreator/issues/112
Can export unoptimized glb ( separated trait models and textures ).
Todo:
No culling.( Done )Clean empty objects.( Done )Prevent export animated emotion, such as the halfway blinking eyes.( Found exported optimized glb has this issue too, better to fix in another PR )