webaverse-studios / CharacterCreator

3D Avatar Creator for Everyone
https://moemate.io
MIT License
84 stars 47 forks source link

compute transition time instead of using constant #254

Closed tcm390 closed 1 year ago

tcm390 commented 1 year ago

Now we are using constant for fade-in transition time which cause the latency of fade-in effect that is because we add the model to the scene before the effect is finished. In this pr, I compute the transition time instead of using constant.

issue:

https://user-images.githubusercontent.com/60634884/215914217-41bf4cca-88fa-43dc-bb37-42958fee2f23.mp4

result:

https://user-images.githubusercontent.com/60634884/215914234-d7ee5336-b47e-48b4-b918-542f93c96064.mp4

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
character-creator ✅ Ready (Inspect) Visit Preview Feb 1, 2023 at 0:22AM (UTC)
gonnavis commented 1 year ago

Confirmed with @tcm390 and tested that , this PR tweaked the time, prevent heavy calculation cause page stuck when particles still exist.

image