webaverse-studios / CharacterCreator

3D Avatar Creator for Everyone
https://moemate.io
MIT License
84 stars 47 forks source link

Fix voice overlap #293

Closed memelotsqui closed 1 year ago

memelotsqui commented 1 year ago

been trying to reduce sound in branch https://github.com/webaverse-studios/CharacterCreator/tree/mem/fix-voice instead of muting abruptly, but for some reason setting gain in audio to 0 is not working. This pr fixes the overlap audio by stopping the current playing audio, and playing the new one.

temporal fix for #263 (better to have it muted abruptly for now than having overlapping audio while i find the fade out audio solution)

https://user-images.githubusercontent.com/1117257/217973678-3482891a-7730-403e-bc53-4337a2738e39.mp4

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
character-creator ✅ Ready (Inspect) Visit Preview Feb 10, 2023 at 1:02AM (UTC)
soulofmischief commented 1 year ago

Lovely, thanks!