search

webaverse-studios / CharacterCreator

3D Avatar Creator for Everyone
https://moemate.io
MIT License
84 stars 47 forks source link

Cleanup dead code #304

Open memelotsqui opened 1 year ago

memelotsqui commented 1 year ago

There is alot of dead code lying around (intialTraits, blinker.js, download model from component), lets make a pr for each dead code block and make sure everything is working correctly after removing the code.

initial traits are not called from app.jsx, but directly from the option-utils script: *app.jsx image

option-utils import image option-utils function image

We are no longer using blinker.js, only blinkManager as it considers loading multiple models

image

ExportMenu.jsx is no longer using download call from internal code, but from downloadUtils

image

image

memelotsqui commented 1 year ago

It appears function getModelFromScene() in src/library/utils.js line 68 is not used anymore (fetching models moved to dowload-utils.js) , will add it here for tracking :)

image