App: Unintended walk/run toggle controls issue on macbooks

webaverse / app

Web metaverse client

https://app.webaverse.com

MIT License

343 stars 207 forks source link

App: Unintended walk/run toggle controls issue on macbooks #1877

Open alisaad673 opened 2 years ago

alisaad673 commented 2 years ago

An issue appeared while doing QA of a specific PR on MacBook m1, whenever I used to record screen by pressing cmd+shift+f5, the avatar would run when W was pressed without pressing or holding shift. I tested more of it, if CMD+SHIFT+F5/F4 is pressed, the avatars movement toggles from walk to run. It Gets fixed again when shift is pressed.

Loryhoof commented 2 years ago

I think it's a pretty common problem for web games, this can probably also be reproduced with:

Having webA and a second tab open
Hold shift walk
Click on the second tab while still shift walking
Click on webA tab again

This way there is no onButtonLeave event, and it gets stuck in that state. So it's not a macbook specific issue

alisaad673 commented 2 years ago

@Loryhoof So it can not be solved?

avaer commented 2 years ago

I think we can solve it by resetting the key state when we blur. I think this is probably a solvable bug.

0reo commented 2 years ago

@ohmed is this UI related?