webaverse / app

Web metaverse client

https://app.webaverse.com

MIT License

338 stars 212 forks source link

Fix avatar physics capsule size mismatch #3624

Closed jakezira closed 1 year ago

jakezira commented 1 year ago

Describe your changes

Updated character controller physx entity's height to cover full body
Updated physics collider rendering to match physx

What are the steps for a QA tester to test this pull request?

See collider of npc or avatar using tilde to check it's boundary compared to mesh.
Jump onto npc or avatar's top to see land height matches it's height

Issue ticket number and link

3601

Screenshots and/or video

See below

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I am not adding any irrelevant code or assets
[x] I am only including the changes needed to implement the change
[x] I have playtested and intentionally tried to find error cases but couldn't

jakezira commented 1 year ago

Related: https://github.com/webaverse/app/pull/3493

Physics collider size:

Physx collide:

alisaad673 commented 1 year ago

Issues:

1/3-Height wise, seems fine. But what about side wise, The arms aren't being catered in the capsule that makes it possible for other vrms appear merged into on another.

https://user-images.githubusercontent.com/35926530/184654149-35dccce1-3cc6-43f4-9986-38e734b464f1.mp4

2/3-The other un-equipped vrms have different capsules. Like gear , miku etc.

3/3-Some of the other vrms don't respect the capsule:

zenkale commented 1 year ago

Closing in favor of Lab's PR