webaverse / app

Web metaverse client
https://app.webaverse.com
MIT License
338 stars 212 forks source link

Redo sword sounds + grunts #3659

Open avaer opened 1 year ago

avaer commented 1 year ago

The sword sounds and grunts were implemented in the silsword app, which is the wrong place: https://github.com/webaverse/silsword/blob/df1cbb2cfb9a8f7eb9967d9159003d6c4e73a84e/index.js#L698

The character shape will change, which it did upstream, and now the silsword crashes, so I removed the grunt.

The grunt should occur, like the footsteps and jump, in response to actions on the avatar, implemented in the character controller system. And the avatar controller should emit a sound point event, so that the sword can play its whoosh sound too (silsword should listen for the event).

@tcm390 https://github.com/webaverse/silsword/blame/df1cbb2cfb9a8f7eb9967d9159003d6c4e73a84e/index.js#L698

avaer commented 1 year ago

https://github.com/webaverse/silsword/commit/0b5316160295ca25aff0711fbbcd1edf04c5d4e1

patriboz commented 1 year ago

Fix: https://github.com/webaverse/app/pull/3694