The character shape will change, which it did upstream, and now the silsword crashes, so I removed the grunt.
The grunt should occur, like the footsteps and jump, in response to actions on the avatar, implemented in the character controller system. And the avatar controller should emit a sound point event, so that the sword can play its whoosh sound too (silsword should listen for the event).
The sword sounds and grunts were implemented in the
silsword
app, which is the wrong place: https://github.com/webaverse/silsword/blob/df1cbb2cfb9a8f7eb9967d9159003d6c4e73a84e/index.js#L698The character shape will change, which it did upstream, and now the silsword crashes, so I removed the grunt.
The grunt should occur, like the footsteps and jump, in response to actions on the avatar, implemented in the character controller system. And the avatar controller should emit a sound point event, so that the sword can play its whoosh sound too (
silsword
should listen for the event).@tcm390 https://github.com/webaverse/silsword/blame/df1cbb2cfb9a8f7eb9967d9159003d6c4e73a84e/index.js#L698