webaverse / app

Web metaverse client
https://app.webaverse.com
MIT License
338 stars 212 forks source link

Wind API is bad #3669

Open avaer opened 1 year ago

avaer commented 1 year ago

This API convention doesn't follow any of the React, metaversefile, or Webaverse conventions:

  getWinds() {
    return world.winds;
  },
  setWinds(wind) {
    world.winds.push(wind);
  },
  removeWind(wind) {
    const index = world.winds.indexOf(wind);
    if (index > -1) {
      world.winds.splice(index, 1);
    }
   },
avaer commented 1 year ago

This probably requires totum updates.