search

webaverse / app

Web metaverse client
https://app.webaverse.com
MIT License
338 stars 212 forks source link

Wind API is bad #3671

Closed tcm390 closed 1 year ago

tcm390 commented 1 year ago

Can we just set winds array in metaversefile-api.js like mirrors?

related: https://github.com/webaverse/app/issues/3669

result:

https://user-images.githubusercontent.com/60634884/187091366-c22c478b-c4e7-4393-83b6-2f96022ca63c.mp4

avaer commented 1 year ago

This isn't really an improvement. If the wind is controllable it should not have bare methods like setWinds. If anything it should go through a manager like everything else.

useEnvironmentManager?

tcm390 commented 1 year ago

Closed. Handle this issue by this PR: https://github.com/webaverse/app/pull/3673