webaverse / app

Web metaverse client
https://app.webaverse.com
MIT License
338 stars 211 forks source link

add timestamp to avatar.setVelocity for remote player #3703

Closed codenametiger closed 1 year ago

codenametiger commented 1 year ago

Based on commit https://github.com/webaverse/app/commit/519fc88e2b3f1a3b4f029099d6b4bd4367ee8af5 Need to add timestamp for setting velocity of avatar of remote player, else it is throwing undefined errors

Describe your changes

add timestamp to avatar.setVelocity for remote player, on remote players this is called from the RemotePlayer -> observePlayerFn where the timestamp is not added as the first parameter

What are the steps for a QA tester to test this pull request?

Run a multiplayer session and check for position update on remote player.

Issue ticket number and link

changes based on commit https://github.com/webaverse/app/commit/519fc88e2b3f1a3b4f029099d6b4bd4367ee8af5

Screenshots and/or video

image

Checklist before requesting a review