webaverse / app

Web metaverse client
https://app.webaverse.com
MIT License
344 stars 207 forks source link

change to characterhups for remote players #3704

Closed codenametiger closed 2 years ago

codenametiger commented 2 years ago

When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player.

Describe your changes

To set up side camera in diorama.js, position, quaternion and scale is obtained from target.matrixworld.decompose which does not seem to be updated for remote player. Hence calculating/composing it in character-controller.js where position and quaternion data is obtained

What are the steps for a QA tester to test this pull request?

1.Go to 'https://local.webaverse.com/?src=.%2Fscenes%2Fprototype.scn&room=fLgYz' 2.Join another player using same link 3.Press 'Enter' to start chat for any one player and observe character hups window showing character diorama and chat on another player screen.

  1. Diorama view for remote player must show the character within the frame for chat character hups window

note: require this pr as well, https://github.com/webaverse/app/pull/3703

Issue ticket number and link

3702

Screenshots and/or video

Img_1 Img_2

Checklist before requesting a review