search

webaverse / xrpackage

XR (VR+AR) web object packaging core API
https://xrpackage.org/
24 stars 10 forks source link

[Test] webxr-template.html imports unknown files #119

Open avaer opened 4 years ago

avaer commented 4 years ago

We see this import line in https://github.com/webaverse/xrpackage/blob/6c15ccf236aee905af8ebe2f4b106dbace3bc1df/tests/static/assets/webxr-template.html#L13

import * as THREE from './build/three.module.js';

This also made its way into https://github.com/webaverse/xrpackage/blob/master/tests/static/assets/webxr-template.wbn

However, this file does not exist, so the whole package is technically broken and will (hopefully) error on load in the future. The tests aren't accounting for this.

We should probably at least make the package valid if it's the intent to have passing tests with loading it.

shu8 commented 4 years ago

https://github.com/webaverse/xrpackage/pull/105 will get rid of the accidental broken package!

https://github.com/webaverse/xrpackage/pull/111 will add a purposefully broken package too (when it's ready!)