search

webaverse / xrpackage

XR (VR+AR) web object packaging core API
https://xrpackage.org/
24 stars 10 forks source link

Blob screenshotting #41

Open avaer opened 4 years ago

avaer commented 4 years ago

The screenshot process for https://github.com/Zetaphor/webxr-blob doesn't capture the correct volume.

blob

We should make sure that the package volume specification is honored, or we need to come up with better default bounds for packages like this.

avaer commented 4 years ago

This might have to do with Firefox; here is a capture of the chicken package where it has the wrong viewport width height or possibly pixel ratio:

chicken

yahengsu commented 4 years ago

Seems to be partially fixed by transparent backgrounds in https://github.com/webaverse/xrpackage/issues/86, but I'll see if I can dig deeper. If it's a firefox issue, maybe using puppeteer will fix the issue as well (since puppeteer is bundled with chromium)?

avaer commented 4 years ago

The bug here is that there is a cutoff in the screenshot.

If we move to puppeteer then indeed the issue would probably at least be universal, rather than depending on what browser the user chooses.