webb-tools / dkg-substrate

Multy-party threshold ECDSA (GG20) Substrate node
https://tangle.webb.tools/
GNU General Public License v3.0
59 stars 15 forks source link

[BUG] Received message for mixed stage #431

Closed shekohex closed 1 year ago

shekohex commented 1 year ago

Describe the bug

Looks like we receive offline messages during a voting stage!

To Reproduce Steps to reproduce the behavior:

  1. Just run the standalone network and watch the logs!

Log output

Log Output ```log WARN tokio-runtime-worker dkg_gadget::async_protocols::incoming: Received message for mixed stage: Local: Voting: proposal = Unsigned { kind: ProposerSetUpdate, data: [187, 176, 113, 76, 107, 33, 104, 247, 92, 245, 129, 62, 151, 247, 9, 184, 123, 66, 188, 40, 64, 81, 186, 79, 134, 67, 223, 15, 58, 84, 234, 50, 0, 0, 0, 0, 0, 0, 234, 96, 0, 0, 0, 3, 0, 0, 0, 2] }, payload: Offline(DKGOfflineMessage { key: [113, 74, 82, 170, 158, 218, 250, 48, 121, 127, 30, 17, 17, 232, 86, 139, 178, 237, 5, 203, 165, 167, 96, 234, 97, 202, 104, 44, 19, 206, 47, 47], signer_set_id: 1, offline_msg: [123, 34, 115, 101, 110, 100, 101, 114, 34, 58, 49, 44, 34, 114, 101, 99, 101, 105, 118, 101, 114, 34, 58, 110, 117, 108, 108, 44, 34, 98, 111, 100, 121, 34, 58, 123, 34, 77, 52, 34, 58, 123, 34, 98, 108, 105, 110, 100, 95, 102, 97, 99, 116, 111, 114, 34, 58, 91, 55, 50, 44, 50, 44, 53, 49, 44, 49, 56, 57, 44, 50, 52, 52, 44, 50, 48, 44, 49, 53, 44, 54, 57, 44, 49, 50, 54, 44, 49, 50, 52, 44, 49, 53, 48, 44, 53, 57, 44, 49, 49, 48, 44, 49, 52, 44, 50, 52, 53, 44, 50, 44, 49, 50, 51, 44, 49, 48, 53, 44, 56, 55, 44, 57, 49, 44, 49, 51, 44, 48, 44, 50, 52, 52, 44, 50, 52, 56, 44, 49, 55, 49, 44, 49, 54, 52, 44, 49, 49, 49, 44, 50, 48, 44, 49, 52, 48, 44, 50, 49, 50, 44, 49, 48, 50, 44, 49, 48, 54, 93, 44, 34, 103, 95, 103, 97, 109, 109, 97, 95, 105, 34, 58, 123, 34, 99, 117, 114, 118, 101, 34, 58, 34, 115, 101, 99, 112, 50, 53, 54, 107, 49, 34, 44, 34, 112, 111, 105, 110, 116, 34, 58, 91, 50, 44, 56, 44, 49, 53, 55, 44, 49, 53, 51, 44, 56, 50, 44, 49, 57, 57, 44, 50, 51, 55, 44, 49, 56, 50, 44, 49, 48, 56, 44, 50, 48, 44, 54, 53, 44, 55, 54, 44, 49, 49, 51, 44, 49, 52, 44, 55, 52, 44, 49, 50, 51, 44, 49, 52, 51, 44, 52, 55, 44, 50, 51, 49, 44, 50, 52, 52, 44, 50, 49, 54, 44, 50, 52, 49, 44, 54, 57, 44, 53, 44, 49, 48, 50, 44, 53, 55, 44, 50, 52, 51, 44, 50, 51, 48, 44, 49, 51, 48, 44, 51, 52, 44, 50, 49, 56, 44, 50, 53, 52, 44, 50, 48, 53, 93, 125, 125, 125, 125], async_index: 0 }) ```

Expected behaviour

We should never see that warning, nor we should send the offline messages to the voting stage! it is harmless, but that means there is a bug somewhere.

Screenshots

Environment (please complete the following information):

Other information and links

dutterbutter commented 1 year ago

@shekohex can you verify that this is still an issue please