search

webb-tools / dkg-substrate

Multy-party threshold ECDSA (GG20) Substrate node
https://tangle.webb.tools/
GNU General Public License v3.0
59 stars 15 forks source link

[WIP] improve signing sets #689

Closed tbraun96 closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 2.21% and project coverage change: -0.23% :warning:

Comparison is base (2c53a31) 17.01% compared to head (2c081ab) 16.78%. Report is 1 commits behind head on master.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #689 +/- ## ========================================== - Coverage 17.01% 16.78% -0.23% ========================================== Files 77 77 Lines 5617 5730 +113 ========================================== + Hits 955 961 +6 - Misses 4662 4769 +107 ``` | [Files Changed](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools) | Coverage Δ | | |---|---|---| | [dkg-gadget/src/async\_protocols/keygen/handler.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvYXN5bmNfcHJvdG9jb2xzL2tleWdlbi9oYW5kbGVyLnJz) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/async\_protocols/mod.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvYXN5bmNfcHJvdG9jb2xzL21vZC5ycw==) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/async\_protocols/remote.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvYXN5bmNfcHJvdG9jb2xzL3JlbW90ZS5ycw==) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/async\_protocols/sign/handler.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvYXN5bmNfcHJvdG9jb2xzL3NpZ24vaGFuZGxlci5ycw==) | `0.00% <0.00%> (ø)` | | | [...adget/src/async\_protocols/state\_machine\_wrapper.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvYXN5bmNfcHJvdG9jb2xzL3N0YXRlX21hY2hpbmVfd3JhcHBlci5ycw==) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/dkg\_modules/mod.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvZGtnX21vZHVsZXMvbW9kLnJz) | `0.00% <ø> (ø)` | | | [dkg-gadget/src/dkg\_modules/mp\_ecdsa.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvZGtnX21vZHVsZXMvbXBfZWNkc2EucnM=) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/gossip\_engine/network.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvZ29zc2lwX2VuZ2luZS9uZXR3b3JrLnJz) | `0.00% <0.00%> (ø)` | | | [...-gadget/src/gossip\_messages/misbehaviour\_report.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMvZ29zc2lwX21lc3NhZ2VzL21pc2JlaGF2aW91cl9yZXBvcnQucnM=) | `0.00% <0.00%> (ø)` | | | [dkg-gadget/src/keygen\_manager/mod.rs](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools#diff-ZGtnLWdhZGdldC9zcmMva2V5Z2VuX21hbmFnZXIvbW9kLnJz) | `0.00% <0.00%> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/webb-tools/dkg-substrate/pull/689?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webb-tools) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drewstone commented 1 year ago

Is this still WIP @tbraun96 ?

tbraun96 commented 1 year ago

Is this still WIP @tbraun96 ?

We can merge this in, but, this will need a part II for handling the case when multiple peers disconnect at once.

drewstone commented 1 year ago

Would be good to get this into the pre test net @1xstj