search

webb-tools / dkg-substrate

Multy-party threshold ECDSA (GG20) Substrate node
https://tangle.webb.tools/
GNU General Public License v3.0
59 stars 15 forks source link

SBP Milestone review 3 #695

Closed hbulgarini closed 1 year ago

hbulgarini commented 1 year ago

The code reflects a team very experienced with something development and there are not so many action items to point out (at least from my point of view).

All the previous items pointed out in the SBP Milestone review 2 were addressed.

I have only spotted one issue that should be addressed which is the extrinsic force_reset_indices. Please refer to the comments in the PR to more details.

1xstj commented 1 year ago

Thankyou, opened issue https://github.com/webb-tools/dkg-substrate/issues/696 to track