The code reflects a team very experienced with something development and there are not so many action items to point out (at least from my point of view).
All the previous items pointed out in the SBP Milestone review 2 were addressed.
I have only spotted one issue that should be addressed which is the extrinsic force_reset_indices. Please refer to the comments in the PR to more details.
The code reflects a team very experienced with something development and there are not so many action items to point out (at least from my point of view).
All the previous items pointed out in the SBP Milestone review 2 were addressed.
I have only spotted one issue that should be addressed which is the extrinsic
force_reset_indices
. Please refer to the comments in the PR to more details.