webb-tools / zero-knowledge-gadgets

Zero-knowledge gadgets for Webb's cross-chain blockchain applications.
Apache License 2.0
89 stars 29 forks source link

Plonk mixer circuit tests #148

Closed GhostOfGauss closed 2 years ago

GhostOfGauss commented 2 years ago

This adds tests to the mixer circuits.  The discussion of which tests to include begins here.

This will close #121 .

lazovicff commented 2 years ago

Try making helper functions for proving/verifying, to make it easier to review

GhostOfGauss commented 2 years ago

All tests are added and working. I also accounted for some changes that occurred in this plonk PR that were breaking tests in poseidon and merkle_tree.

The only thing I have not addressed is @filiplazovic 's suggestion to use a helper function for proving/verifying. I started doing it and got tripped up by traits. If you think it's important to do then I can go back and figure that out, though. Just let me know.