19 carbon accounting - Githubissues

webber-energy-group / HOwDI

https://howdi.readthedocs.io/en/develop/

GNU General Public License v3.0

0 stars 0 forks source link

19 carbon accounting #24

Closed bradenpecora closed 2 years ago

bradenpecora commented 2 years ago

This is kind of a large pull request, not sure if its worth going over everything or anything. The most important file is hydrogen_model.py followed by create_network.py. P.S: It is much easier to compare pull requests in VSCode through the GitHub Pull Requests extension (probably have to git fetch first). On GitHub and in VSCode, you can browse by commit, which may be a better way of looking at things? I'm not 100% perfect with my commits.

embeagle commented 2 years ago

For @bradenpecora (please and thank you):

add back in U_carbon term and equation
change cons_checs to cons_h2
change breakevenCarbon name to avoided_emissions

For @embeagle :

review current breakevenCarbon values
change to t CO2/tH2 units