search

webbingbrasil / filament-copyactions

A easy-to-use copy actions for Filament Admin Pages, Tables and Form Fields.
56 stars 15 forks source link

Remove custom xdata #18

Closed dmandrade closed 1 year ago

dmandrade commented 1 year ago

Remove custom xdata to prevent conflict with action tooltip

Resolve #14

chosten commented 1 year ago

I'm not sure that it will work if you put a quote in the copyable or the success notification title. Shouldn't you escape them? Maybe like this: 'x-on:click' => new HtmlString('window.navigator.clipboard.writeText('.json_encode($this->getCopyable()).'); $tooltip('.json_encode($this->getSuccessNotificationTitle()).');')

dmandrade commented 1 year ago

I returned the escape I had using Js::from() on pr #21

chosten commented 1 year ago

Thank you, I think it's safer.

dmandrade commented 1 year ago

Any problem you can open another issue or a pr