webbukkit / DynmapBlockScan

Tool to scan post-1.8 MC blocks and JSON model data to automatically generate Dynmap models
63 stars 30 forks source link

[All the Mods v3.03] [MC v1.10.2] Crash when adding DynmapBlockScan #12

Closed kaiserdj closed 5 years ago

kaiserdj commented 6 years ago

https://gist.github.com/kaiserdj/5d883d62d4002477f07cd8bcd326bfd5

hcardwell commented 6 years ago

I believe I have the identical crash in a variation on that modpack. I am running ATM: Expert Remastered v1.1.1, but it appears to be the same crash.

Full log: https://gist.github.com/hcardwell/cdc41bc0b6ea5caa195fd299579f01b4

Relevant snippet: [12:42:37] [Server thread/ERROR] [FML/]: The following problems were captured during this phase [12:42:37] [Server thread/ERROR] [FML/]: Caught exception from DynmapBlockScan (dynmapblockscan) java.lang.NullPointerException at org.dynmap.blockscan.blockstate.Variant$Deserializer.deserialize(Variant.java:111) ~[Variant$Deserializer.class:?] at org.dynmap.blockscan.blockstate.Variant$Deserializer.deserialize(Variant.java:105) ~[Variant$Deserializer.class:?] at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[TreeTypeAdapter.class:?] at com.google.gson.Gson.fromJson(Gson.java:803) ~[Gson.class:?]

kaiserdj commented 6 years ago

Pliss fixed this

adampaulberg commented 6 years ago

I am having this same issue. It's failing on both Windows and Ubuntu

mikeprimm commented 6 years ago

@kaiserdj DynmapBlockScan is server only - your initial report shows a forge client log : it MIGHT work standalone/SSP, but no promises.

Try latest builds of DynmapBlockScan and DynmapForge - patch applied that should handle what looks to be the cause of these exceptions.

hcardwell commented 6 years ago

@mikeprimm Hijacking reply as I made the same error? For what it's worth, I was under the impression that Dynmap itself was functionally server-only, but the block scan stuff needed the client rendering engine running to get the textures / voxel type to build the cache. So I was running DynmapBlockScan in a client in order to build the cache to drop on the server. I'll try the new builds later today and provide more feedback as I am able. Thanks for the work!

mikeprimm commented 6 years ago

You're assuming DynmapBlockScan works like the older DynmapModScraper - which is understandable, but incorrect. DynmapBlockScan never needs to be on a client, and is expected to ultimately be merged with Dynmap itself (once I get more time to finish the core implementation and the rest - it's kind of a huge effort...). That said, it probably CAN work on an SSP system, but I honestly haven't tested it (or considered doing so as a priority, at least during the alpha/primary development stage). In any case, the patch I just made SHOULD help - or, at least, affect - the problem you saw, so give it a spin and let me know if new or different 'smoke' comes out.

adampaulberg commented 6 years ago

I couldn't successfully get gradle to build this. I'm not sure what i'm doing wrong. Will this code build into http://www.dynmap.us/builds/DynmapBlockScan/ ? If so, the lastest jar in the DynmapBlockScan folder still crashes my server on startup.

hcardwell commented 6 years ago

@mikeprimm Sorry for the delays. Your January 6 builds do indeed run on my ATM:Expert Remastered 1.1.1 server. The Dynmap view is rendering a few additional block types from mods, but many (most?) mod blocks still are not rendering. Some are mis-rendering (presumably entity types rather than blocks?) like cables rendering as bedrock. I had cleared all the map contents and did a radius render for testing. If there is utility in seeing the logs let me know and I'll upload them. Thank again for your continued work on this mod. I think it is really awesome.

mikeprimm commented 6 years ago

Please try latest version of Dynmap v3.0 and DynmapBlockScan - there have been a couple of other fixes that, in particular, help with 1.10.2 (which is a version that I backported to, by request, but hasn't been the primary focus of the DynmapBlockScan and v3.0 development).

hcardwell commented 6 years ago

@mikeprimm I do not see commits for DynmapBlockScan on Github newer than the Jan 6 ones that I believe are in the current builds posted under dynamp.us/builds. Checked both Master and the 1.10.2 branch. Also, buddies and I finished ATM:Expert Remastered and moved to Age of Engineering. Still a 1.10.2 modpack, but makes this thread issue title even less relevant. Happy to continue help testing as I am able though. I think Dynmap is awesome. Thanks!

hcardwell commented 6 years ago

Follow-up: with today's build of DynMap and the Jan 6 build of DynmapBlockScan, a few mod-based voxels (notably ones from Forestry) are rendering fine. Most do not appear to be, and render as black squares in "Flat" and black voxels in "surface". No crashes or anything, and renders appear performant. Let me know what else I can do. Not an exhaustive test, but I will leave it running to report back.

mikeprimm commented 6 years ago

Please try with latest build - http://dynmap.us/builds/DynmapBlockScan/ and latest Dynmap alpha (http://dynmap.us/builds/dynmap/ for dev builds, http://dynmap.us/releases for formal alphas)