webbukkit / DynmapBlockScan

Tool to scan post-1.8 MC blocks and JSON model data to automatically generate Dynmap models
63 stars 30 forks source link

[1.12.2] Problem with Biomes O' Plenty #16

Open LiskoSlayer63 opened 6 years ago

LiskoSlayer63 commented 6 years ago

I'm using Biomes O' Plenty and noticed that sometimes the blocks render like they should, but about 80% of time they are rendered black. Why is that happening?

Console outputs the following and I think it might be related: [Server thread/FATAL] [Dynmap]: [Dynmap] Block biomesoplenty:grass:3 - not enough textures for faces (10 > 6)

DynmapBlockScan version: 3.0-alpha-1-1 Dynmap version: 3.0-alpha-1-3 Biomes O' Plenty version: 7.0.1 Forge version: 14.23.1.2561 SpongeForge version: 2555-7.0.0-BETA-2764 Minecraft version: 1.12.2

Screenshot: screenshot-2017-12-23 lizcraft server map

ChubbyPitbull commented 6 years ago

I believe this issue may be the same as this one.

generrosity commented 6 years ago

Try the latest HEAD scan and map - works wonders on the majority of blocks

LiskoSlayer63 commented 6 years ago

@generrosity Still happening, using the 3.x HEAD version of Dynmap and not the 3.0 alpha.

generrosity commented 6 years ago

Sorry, just confirming your using the head blockscan? You might want to delete/ rename the dynmap directory too, certainly rerender

LiskoSlayer63 commented 6 years ago

I downloaded it here, but just realized that there's not updated version for 1.12.2. Where I can find the blockscan head?

Also I have been wondering that when I download the dynmap should I choose the 3.0-alpha or the HEAD-3.x and whats the difference between these two? I download them from here.

generrosity commented 6 years ago

Yea its the right places. HEAD is usually newer but looks like he's promoted it to Alpha :)

Sorry - no idea on 1.12 then - just providing the usual tips that sometimes people miss. I'm sure my 1.12 ATM3 was rendering BoP but I de'commed that now.

LiskoSlayer63 commented 6 years ago

It renders it mostly fine, but it feels like that one block has it own will. Sometimes it renders, sometimes not. Everytime it says that same thing, [Server thread/FATAL] [Dynmap]: [Dynmap] Block biomesoplenty:grass:3 - not enough textures for faces (10 > 6), though.

generrosity commented 6 years ago

like ... randomly? Like if you do radius render its random? Or between reboots?

Or do you mean some specific dirt and tree blocks of the Biomes o Plenty get rendered? Digging for info 😜

LiskoSlayer63 commented 6 years ago

Yeah, randomly, between reboots. It happens only for this one dirt/grass block, every other block is rendered fine. You can see the map here.

generrosity commented 6 years ago

Weird! Definitely looks like random chunks haven't rendered right. I imagine you havent done a fullrender for a while either.

Previously what I did was disable the blockscan once the files generated. Then made a backup of the renderdata/modsupport folder! AFAIK you only need the blockscan to work once. Then you can just fullrender the map and it should always work

LiskoSlayer63 commented 6 years ago

I made that once, if I remove the BlockScan all modded blocks are rendered as black when dynmap updates a tile. You are right that I haven't done fullrender for a while, I don't want to do that because it might render all of those dirt blocks black instead of a few chunks which have been updated by player activity.

generrosity commented 6 years ago

weeeeeeird - removing blockscan should keep the files in that dynmap\renderdata folder... as you should be able to blockscan on a desktop and copy to a server with just dynmap if you wanted to.

I end up using /dynmap reload a lot just to reload all the textures, map definitions, and custom lighting Im testing. Id certainly confirm you have the renderdata files (and backed up), try it without blockscan (maybe on a test instance or client?), and confirm with quick little /dynmap radiusrender 10 commands.

LiskoSlayer63 commented 6 years ago

Renderdata folder is empty, it has always been empty.

I tried the radiusrender without dynmap, here's the result: this_is_what_happens

So like I said, if I remove it every modded block disappears (You can see the snow blocks disappear)

generrosity commented 6 years ago

I suspect that might be your problem - that I would be baffled from my little understand why it works when its present.

Try these two files in the renderdata folder (without blockscan). It would be interesting if blockscan deletes those files too, or if the folder permissions on renderdata block java from creating new folders and files.

biomesoplenty-models.txt biomesoplenty-texture.txt

LiskoSlayer63 commented 6 years ago

I'll try those. The readme file in renderdata folder says that most renderdata files are internal, that explains why there's no files.

generrosity commented 6 years ago

Yea. As far as I'm aware, the whole purpose of blockscan is creating these files on the spot ... Crossed fingers

LiskoSlayer63 commented 6 years ago

But how the other mod blocks render without the files?

generrosity commented 6 years ago

What other mods do your have? Foolcraft has maybe 50 not on the included dynmap list... And I have to admit the creator proberbly included biomes o plenty in the core dynmap after the recent good renders

LiskoSlayer63 commented 6 years ago

I have ~90 mods on the server, everything renders fine, except multiblock structures and that one dirt/grass block. Those files you gave didn't get removed but either didn't work, still getting the same [Server thread/FATAL] [Dynmap]: [Dynmap] Block biomesoplenty:grass:3 - not enough textures for faces (10 > 6).

Dynmap loads all the mods as they should, internally, byt it just fails to get textures for that block.

generrosity commented 6 years ago

Nice!

Sweet, i can only hope there is much more info for the coders to look over when they try to replicate and fix it now

LiskoSlayer63 commented 6 years ago

Yeah, let's hope that someday that grass block is there and stays there.

mikeprimm commented 6 years ago

Just pushed a partial fix - grab latest DynmapBlockScan (and be sure you have current Dynmap v3.0 to match it).