search

webbukkit / dynmap

A set of Minecraft mods that provide a real time web-based map system for various Minecraft server implementations.
https://www.reddit.com/r/Dynmap/
Apache License 2.0
2.03k stars 414 forks source link

Folia Support #3958

Open geferon opened 1 year ago

geferon commented 1 year ago

Feature Description: Currently the PaperMC dev team is working on a Paper fork called Folia which adds support for Multi-threaded minecraft. The issue with this is that, this obviously breaks some plugins, so their solution for it is making it so only plugins that have support for Folia can run in Folia (with a property in the plugin.yml file). Some plugins are supported out of the box whereas others need some refactoring to be able to be supported. I'm not sure of where Dynmap stands between these two, but nonetheless it would be nice to have suport for this in the future.

I can try to see how well it works with Folia or if Dynmap breaks with Folia, and perhaps also do a PR if necessary.

Folia: https://github.com/PaperMC/Folia

JurgenKuyper commented 1 year ago

Dynmap is currently not compatible with folia, probably because our chunkloading is not multihread capable, feel free to see if you can get it to work and create a PR!

mikeprimm commented 1 year ago

Once Folia is released (GA, not beta), we'll evaluate supporting it. I think it is very likely that I will support it - but no commitments until I see both the released product and the resulting final API and model changes: Dynmap also has an API, and your intended changes will also have a nontrivial effect on that (since anyone calling us is now not necessarily doing so from the singular server thread, even if the command/call being issued is relevant to data on another world or on a different region of the same world...), so supporting Folia is also about supporting an API suitable to other Folia-enabled plugins for us.

Please do NOT do a PR - until I've done the evaluation to decide whether we'll support it, there is no way I'll accept it - and doing that evaluation will involve the design work that will effect the implementation across all platforms (since I'm NOT making the 95% common code for Dynmap split for the sake of one new platform...).

geferon commented 1 year ago

Alrighty, makes sense! Should I leave this issue open until then?

mikeprimm commented 1 year ago

Sure - it's a good placeholder, and it'll hopefully avoid folks opening additional ones.... (not counting on it, but it cannot hurt!)

ImAhmadAbdullah commented 10 months ago

Any updates?

mikeprimm commented 10 months ago

No plans at this time - will be evaluated sometime after initial Folia GA/supported release.

SneakyHub commented 5 months ago

Folia looks extremely promising. I do hope you guys look into supporting it.