search

webbukkit / dynmap

A set of Minecraft mods that provide a real time web-based map system for various Minecraft server implementations.
https://www.reddit.com/r/Dynmap/
Apache License 2.0
2.06k stars 419 forks source link

Stained glass custom blocks colors dont match #577

Closed lipe123 closed 12 years ago

lipe123 commented 12 years ago

Nothing serious but the spout custom blocks that allow glass to be colored does not show up in the right color on the map.

If you look at http://lipe123.dyndns.org/ the cockpits of the fighter jets on the aircraft carrier is supposed to be red tint but each side of the block has a diff color - none of which is red XD.

Still just kudos for supporting custom blocks.

mikeprimm commented 12 years ago

Cool - I might have gotten the order of the sides wrong (which direction is first, second, third, in the block side sequence). If you can throw me a pointer to the plugin and custom block definitions you're using, I'd appreciate it

lipe123 commented 12 years ago

does this help: http://forums.spout.org/threads/fun-stainedglass-v0-1-1-making-purdy-glass-spn721-cb1818.224/

mikeprimm commented 12 years ago

Yep - that was what I needed. I've got to get the SpoutPlugin guys to make some changes to get this working right (although I might be able to work around it in the mean time) - their API doesn't give me access to the information I need to know which tiles is on which face, and this plugin doesn't follow the pattern used by SpoutMaterials (which is either one-tile-per-block, same on all sides; or one sequence of tiles, following a specific pattern of tiles to faces), which is what let me work around the lack of the API features thus far. What you're seeing is the result of my logic incorrectly interpreting the multi-tile texture used by stained glass (one tile per color) as meaning a one tile per face mapping (hence, the different colors).

mikeprimm commented 12 years ago

OK - give latest 0.31 dev build a spin - should be working now

lipe123 commented 12 years ago

Actually: 2012-02-03 23:21:27 [SEVERE] Error occurred while enabling dynmap v0.31-818 (Is it up to date?): 240 java.lang.ArrayIndexOutOfBoundsException: 240 at org.dynmap.hdmap.TexturePack.findOrAddDynamicTile(TexturePack.java:1451) at org.dynmap.hdmap.TexturePack.loadTextureFile(TexturePack.java:1025) at org.dynmap.hdmap.TexturePack.loadTextureMapping(TexturePack.java:882) at org.dynmap.DynmapCore.enableCore(DynmapCore.java:254) at org.dynmap.bukkit.DynmapPlugin.onEnable(DynmapPlugin.java:385) at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:231) at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:1057) at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:379) at org.dynmap.bukkit.DynmapPlugin$BukkitServer.reload(DynmapPlugin.java:109) at org.dynmap.DynmapCore.processCommand(DynmapCore.java:781) at org.dynmap.bukkit.DynmapPlugin.onCommand(DynmapPlugin.java:430) at org.bukkit.command.PluginCommand.execute(PluginCommand.java:40) at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:168) at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:386) at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:777) at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:737) at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:725) at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java:176) at net.minecraft.server.Packet3Chat.handle(Packet3Chat.java:33) at net.minecraft.server.NetworkManager.b(NetworkManager.java:226) at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:100) at org.getspout.spout.SpoutNetServerHandler.a(SpoutNetServerHandler.java:552) at net.minecraft.server.NetworkListenThread.a(NetworkListenThread.java:78) at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:537) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:435) at net.minecraft.server.ThreadServerApplication.run(SourceFile:465)

mikeprimm commented 12 years ago

What other custom block mods do you have?

lipe123 commented 12 years ago

Spoutshops & Jukebukkit

I think besides stained glass thats the only ones

mikeprimm commented 12 years ago

Yep - Jukebukkit is registering bad information for its custom blocks. Working around incorrectly coded plugins is getting to be a burden.....

mikeprimm commented 12 years ago

OK - try new 0.31 build

lipe123 commented 12 years ago

Ah you were to fast for me, I was going to suggest just adding escape clause to ignore the older non-compat stuff like jukebukkit.

Will try that one later today and let you know, thanks for looking into this.

edit Works like a charm! Awesome tyvm

Ps. Had a chance to look at: https://github.com/webbukkit/dynmap/issues/565

mikeprimm commented 12 years ago

Yep - the max age sounds like the way to go there.