search

webcat12345 / ngx-intl-tel-input

Phone number input field to support international numbers, Angular
MIT License
212 stars 330 forks source link

Accessibility issues #225

Open mmzhai opened 4 years ago

mmzhai commented 4 years ago

Thanks for the great library. We had an accessibility audit couple of issues for this library popped up:

  1. the combobox may not be the optimal aria role (since there is no text input). Recommended pattern is the button menu: https://www.w3.org/TR/wai-aria-practices-1.1/examples/menu-button/menu-button-actions-active-descendant.html

  2. When there are preferredCountries set, they appear twice in the dropdown resulting in the same label being duplicated. It might make sense if when a country is set as default, it gets removed from the list underneath.

Thanks!

pasevin commented 4 years ago

Thanks for the feedback. Currently, I'm the only one who is maintaining this library :) I will keep this in mind! Please submit a PR if you do any fixes from your side.