webcatalog / webcatalog-legacy

Legacy code of the WebCatalog app.
https://webcatalog.io/webcatalog/
Mozilla Public License 2.0
532 stars 85 forks source link

feature: in-app PDF reader #542

Closed quanglam2807 closed 4 years ago

quanglam2807 commented 4 years ago

Feature Request

Describe the Feature Request

Dear support, I have found these issues with the app: - when a page wants to show a pdf, the app created with webcatalog asks for downloading it instead to show it - when a click to open in a new window, anything is loaded - tabs support is a must (I've seen in github that is a future in development) My apps are Gmail, Zoho Books, Clickup. Thanks Best regards / Fabio

Describe Preferred Solution

Describe Alternatives

Additional Context

linonetwo commented 4 years ago

mozilla/pdfjs

quanglam2807 commented 4 years ago

https://stackoverflow.com/questions/52844135/how-to-view-a-pdf-in-an-electron-browserwindow

PDF Reader is disabled by Electron team. It'll be available with Electron 10 release. https://github.com/electron/electron/pull/21794

quanglam2807 commented 4 years ago

Blocked by https://github.com/electron/electron/issues/22178