webcenter-fr / elasticsearch-operator

Elasticsearch operator that work with all license type
MIT License
3 stars 1 forks source link

fix: fix basic reconciler #112

Closed disaster37 closed 1 year ago

disaster37 commented 1 year ago

Clean code with use of standard methode to reconcile K8s resource.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 58.07% and project coverage change: -1.00% :warning:

Comparison is base (ba19a81) 52.72% compared to head (9b26df2) 51.73%. Report is 4 commits behind head on main.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #112 +/- ## ========================================== - Coverage 52.72% 51.73% -1.00% ========================================== Files 264 264 Lines 27680 25612 -2068 ========================================== - Hits 14594 13250 -1344 + Misses 12225 11505 -720 + Partials 861 857 -4 ``` | [Flag](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr) | `51.73% <58.07%> (-1.00%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr) | Coverage Δ | | |---|---|---| | [apis/elasticsearch/v1/elasticsearch\_types.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-YXBpcy9lbGFzdGljc2VhcmNoL3YxL2VsYXN0aWNzZWFyY2hfdHlwZXMuZ28=) | `100.00% <ø> (ø)` | | | [apis/elasticsearch/v1/zz\_generated.deepcopy.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-YXBpcy9lbGFzdGljc2VhcmNoL3YxL3p6X2dlbmVyYXRlZC5kZWVwY29weS5nbw==) | `0.00% <0.00%> (ø)` | | | [controllers/cerebro/builder\_configmap.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvY2VyZWJyby9idWlsZGVyX2NvbmZpZ21hcC5nbw==) | `95.94% <ø> (ø)` | | | [controllers/cerebro/builder\_ingress.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvY2VyZWJyby9idWlsZGVyX2luZ3Jlc3MuZ28=) | `90.16% <ø> (ø)` | | | [controllers/cerebro/builder\_secret\_application.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvY2VyZWJyby9idWlsZGVyX3NlY3JldF9hcHBsaWNhdGlvbi5nbw==) | `87.50% <ø> (ø)` | | | [controllers/elasticsearch/builder\_configmap.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvZWxhc3RpY3NlYXJjaC9idWlsZGVyX2NvbmZpZ21hcC5nbw==) | `93.87% <ø> (ø)` | | | [controllers/elasticsearch/builder\_ingress.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvZWxhc3RpY3NlYXJjaC9idWlsZGVyX2luZ3Jlc3MuZ28=) | `92.00% <ø> (ø)` | | | [controllers/elasticsearch/builder\_license.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvZWxhc3RpY3NlYXJjaC9idWlsZGVyX2xpY2Vuc2UuZ28=) | `89.28% <ø> (ø)` | | | [controllers/elasticsearch/builder\_loadbalancer.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvZWxhc3RpY3NlYXJjaC9idWlsZGVyX2xvYWRiYWxhbmNlci5nbw==) | `100.00% <ø> (ø)` | | | [controllers/elasticsearch/builder\_pdb.go](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr#diff-Y29udHJvbGxlcnMvZWxhc3RpY3NlYXJjaC9idWlsZGVyX3BkYi5nbw==) | `85.00% <ø> (ø)` | | | ... and [103 more](https://app.codecov.io/gh/webcenter-fr/elasticsearch-operator/pull/112?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webcenter-fr) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.