search

webcerebrium / java-binance-api

Java Binance API Client
MIT License
74 stars 40 forks source link

Do not send `timeInForce` flag for Market orders (Fixes #8) #9

Closed elsehow closed 6 years ago

elsehow commented 6 years ago

Currently, the timeInForce flag is set for all orders. However, the API does not allow us to send this flag for Market orders.

This PR assures that a timeInForce flag is not sent for orders of type MARKET, fixing #8.

Additionally, it does not throw an error if the timeInForce flag is not set, as this flag is optional according to API specifications.

wcrbrm commented 6 years ago

thanks for your contribution

please use code from master branch, it ended up not exactly what was in your PR.

We're usually packaging and sending to maven central releases closer to weekend, when it is tested enough, and ready to be included in release

elsehow commented 6 years ago

Thanks, sorry for the branch confusion.