webcomics / dosage

dosage is a comic strip downloader and archiver
https://dosage.rocks/
MIT License
125 stars 59 forks source link

Handle filename clashes #127

Closed mihkelader closed 5 years ago

mihkelader commented 5 years ago

Dosage doesn't download new comic if there already is one using the same filename(s). Perhaps local files could be stored with unique names (hash of original URL)?

https://www.pidjin.net/2019/02/04/skimpy-armor/ is not downloaded correctly because earlier https://www.pidjin.net/2018/11/05/face-recognition/ uses the same image file names.

TobiX commented 5 years ago

I'm not a fan of unreadable file names 😉

The module for that comic should probably use an appropriate namer, something like this: https://github.com/webcomics/dosage/blob/e7410ce26b5f92c1cfffe803c430c0f89c09e92e/dosagelib/plugins/z.py#L78-L80 If you want to take a stab at a fix, please open a pull request - otherwise I will add something later.