webcomics / dosage

dosage is a comic strip downloader and archiver
https://dosage.rocks/
MIT License
125 stars 59 forks source link

throttling would be extremely useful. #179

Closed nerdguy1338 closed 3 years ago

nerdguy1338 commented 4 years ago

Grrl Power blocks downloading too many pages in a specified time. if i could add an argument to sleep after each strip, that would probably fix it.

also, how do i run this from source? ./dosage doesn't exist.

Ruthalas commented 4 years ago

I can answer your second question- This tool cannot be run from source without being 'installed'. See issue 145 for some information on that.

TobiX commented 4 years ago

Throttling is implemented, but probably needs some per-module fine-tuning. See for example:

https://github.com/webcomics/dosage/blob/e64635e86b2e2fa0efac36fb23a9507f472df859/dosagelib/plugins/comicsherpa.py#L16

nerdguy1338 commented 4 years ago

Ok, thanks, but I've installed this as a pip module, how do I edit that code?

On Thu, Nov 5, 2020, 2:27 AM Tobias Gruetzmacher notifications@github.com wrote:

Throttling is implemented, but probably needs some per-module fine-tuning. See for example:

https://github.com/webcomics/dosage/blob/e64635e86b2e2fa0efac36fb23a9507f472df859/dosagelib/plugins/comicsherpa.py#L16

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/webcomics/dosage/issues/179#issuecomment-722196290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZOBBGHNLLAOCIFDTY44E3SOJHWJANCNFSM4TK3XJ2Q .

TobiX commented 4 years ago

See the README (without the last sentence about the dosage script, that is deprecated) - You want to install dosage in "editable" mode, after that your git checkout is the "installed" version.

nerdguy1338 commented 4 years ago

Ok thanks, I've got an editable version now, but I don't really understand where the throttle code goes, I've tried just inserting it into the grrl power class definition, but then it just pukes all over itself.

On Thu, Nov 5, 2020, 3:03 AM Tobias Gruetzmacher notifications@github.com wrote:

See the README https://github.com/webcomics/dosage#installation-for-development (without the last sentence about the dosage script, that is deprecated) - You want to install dosage in "editable" mode, after that your git checkout is the "installed" version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/webcomics/dosage/issues/179#issuecomment-722211967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZOBBDCE6TAAZNZ2YMGSCDSOJL4DANCNFSM4TK3XJ2Q .