search

webcomm / magento-boilerplate

HTML5 Twitter Bootstrap 3.1 Magento Boilerplate Template
MIT License
526 stars 191 forks source link

Language Attribute not in html tag #166

Open jg-development opened 7 years ago

jg-development commented 7 years ago

Hi,

the main templates does not have the lang attribute in the html tag. Instead of:

<!DOCTYPE html>
<html>

it should be something like that

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php echo $this->getLang() ?>" lang="<?php echo $this->getLang() ?>">

Greetings Jan

bencorlett commented 7 years ago

You're referring to XHTML in your example there in conjunction with the language attribute. These are two separate concepts :)

I am happy to add in the language attribute, please send through a Pull Request :)

Sent from my iPhone

Please excuse my brevity

On 5 Jan 2017, at 11:00 pm, jg-development notifications@github.com wrote:

Hi,

the main templates does not have the lang attribute in the html tag. Instead of:

<!DOCTYPE html>

it should be something like that Greetings Jan — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
jg-development commented 7 years ago

In that case .... I created a pull request for the lang attribute only XHTML is truely another concept