Closed adamopenweb closed 10 years ago
miketaylr
commented
10 years ago Makes sense.
Two solutions come to mind:
Solution 2 has the benefit of not generating bugmail.
karlcow
commented
10 years ago hmm interesting. Adding a new description which is very similar to the default one already proposed seems not to be the most effective way. I do add new description tags but when they explained the issue more in details or when the HTTP requests show what is happening. Simplebug top is there for human without tech knowledge but description/suggestedfix are there for tech people. :)
if the generic message is not good enough, then we should instead hook it up in simple bug and modify it by something which we like instead of adding the same prose in a different style.
adamopenweb
commented
10 years ago Karl: I agree, I would like to have a very techy description but out of the context of the bug our comments don't make a lot of sense. Sometimes we have all the right information in the bug but in different comments.
Description of bug (not picking on Lawrence, just a good example) doesn't make much sense in Simplebug: "vatera.hu serves a desktop site to B2G. Bug 823364 added an UA override for this domain. The override should be removed once the domain serves mobile content to B2G. This bug tracks the evangelism for the site to recognize the B2G UA and the removal of the override at that time."
Hallvord's comment is good info too but not on its own: "iPhone UA:
GET / HTTP/1.1 Host: www.vatera.hu User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 50 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3 Accept: text/html,application/xhtml+xml,application/xml;q=0.9,/_;q=0.8 .... etc."
karlcow
commented
10 years ago @adamopenweb See for an example of description and suggestedfix
http://webcompat.com/simplebug/?id=827674
If the message from Lawrence doesn't make enough sense, let's fix that :). What I said by fixing the generic description. btw it should be already partially fixed in the code. Maybe not good enough (we can improve) but see
https://github.com/webcompat/simplebug/blob/master/scripts/main.js#L51
The issue is that it is not applied to the current description. "Houston, We have a bug". Example http://webcompat.com/simplebug/?id=843119
hallvors
commented
10 years ago We should fix the "lingo replacement not applied to current description" bug (Mike, can you take care of it?), but we may still have cases where we want the default description to be used instead of anything in the bug report. What about tagging the first comment simplebug_ignore ? https://bugzilla.mozilla.org/show_bug.cgi?id=878253#c0
Logic then becomes:
miketaylr
commented
10 years ago We should fix the "lingo replacement not applied to current description" bug (Mike, can you take care of it?)
Sure, I think we just apply that to bug titles, right?
Logic then becomes:
If any comment is tagged "description", use it. Otherwise..
If first comment is tagged "simplebug_ignore", fall back to default. Otherwise..
If there is no first comment, fall back to default. Otherwise..
Use first commentThis makes sense to me.
hallvors
commented
10 years ago No, I apply it to bug comments too. Or I thought I did.. :-p
miketaylr
commented
10 years ago OK, so I've fixed this issue in my fork: https://github.com/webcompat/simplebug/commit/8b9a50196d18410522494d320052504d855cbbd5#diff-1158547f6c0d51a619395b777ca816efR68
Note that I used "simplebug-ignore" (dash instead of underscore).
In many cases I am adding a new description into a bug and setting a description flag. If there was an input flag that forces default descriptions for simplebug, would be cleaner in the bug. Example: https://bugzilla.mozilla.org/show_bug.cgi?id=878253
This may not be worth doing and that's OK, though I'd bring it up. Low priority.