webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
746 stars 66 forks source link

www.hannaandersson.com - Some promo images in the carousel are not displayed #100779

Closed softvision-oana-arbuzov closed 2 years ago

softvision-oana-arbuzov commented 2 years ago

URL: https://www.hannaandersson.com/

Browser / Version: Firefox Nightly 100.0a1 (2022-03-09) Operating System: Windows 10 Tested Another Browser: Yes Chrome

Problem type: Design is broken Description: Images not loaded Steps to Reproduce:

  1. Navigate to https://www.hannaandersson.com/
  2. Close "Cookies" popup.
  3. Check the carousel under the "Promo Details" link.

Expected Behavior: All images are displayed.

Actual Behavior: Some images are not displayed.

Notes:

  1. Screenshot attached.
  2. The issue is not reproducible on Chrome 99, Chrome 100, Firefox Release, and Firefox Beta.
  3. The issue is reproducible on Firefox Nightly regardless of the ETP status.
  4. Randomly the carousel does not load at all. image

Affected area:

<div class="heroCarousel is-SP22-hp-carousel-T1-2-0303 wide-carousel" data-promopos="12c015dc35a8a7c611e4251237" data-promoname="Spring Break Apparel/ Swim Shop/ Easter Dressing/Easter PJs" data-template="heroCarousel" data-contentid="SP22-hp-carousel-T1-2-0303" data-clicked="carousel" data-click-state="1">
  <span class="accessible-slider-control" role="button" aria-label="Pause featured collections carousel carousel" data-slider-control="true" tabindex="0"></span>
  <div class="MagicScroll" data-label="[control] slide, featured collections carousel" data-options="items: 1; step: 1; width: auto; arrows: inside; pagination: true; scrollOnWheel: false; keyboard: true; autoplay: 4000;">
    <div class="ms-slide first-slide" style="">
      <div class="hero__content-container hero__content-container--horizontal js-carousel-content cursor-pointer js-link wide-content" data-url="/new-arrivals-shop">
        <div class="hero__content--horizontal hero__content">
          <picture>
            <source media="(max-width: 640px)" srcset="https://cdn-vzn.yottaa.net/5d02a70c4f1bbf63c39ca930/www.hannaandersson.com/v~4b.d5/dw/image/v2/BBLM_PRD/on/demandware.static/-/Sites-hannaandersson-Library/default/dw9562926e/images/homepage/2022-02-22_HPCarousel_1_m.jpg?sw=640&amp;sfrm=png&amp;yocs=T_U_">
<--!cut out-->
</div>

Watchers: @softvision-oana-arbuzov @softvision-raul-bucata

View the screenshot Screenshot
Browser Configuration
  • None

From webcompat.com with ❤️

softvision-oana-arbuzov commented 2 years ago

I've managed to do mozregression, while considering bad - carousel only showed 2 images and good - carousel showed all images

Last good revision: 76e3d23e8250f170539ff2e8d28477c71dbb26c2 First bad revision: e7789479b06c32240e36a3e9d278cc0082f67fe5 INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=76e3d23e8250f170539ff2e8d28477c71dbb26c2&tochange=e7789479b06c32240e36a3e9d278cc0082f67fe5

[inv_10/2022]

ksy36 commented 2 years ago

I can't reproduce this, seems to be loading pretty consistently. @softvision-oana-arbuzov could you please check if it's still an issue?

softvision-oana-arbuzov commented 2 years ago

@ksy36 with three different Firefox Nightly profiles, the carousel does not load at all for me now (site resized to fit the screen). ![image](https://user-images.githubusercontent.com/12184325/158358933-5f284

Tested with: Browser / Version: Firefox Nightly 100.0a1 (2022-03-14) Operating System: Windows 10 Pro

[inv_11/2022]

karlcow commented 2 years ago

fwiw I get a flurry of denied requests for one of their cdn.

Capture d’écran 2022-03-17 à 14 37 01

karlcow commented 2 years ago

This is related to version 100. Switching to Firefox 99 and it fixes the issue.

The CDN doesn't understand Firefox 100. https://cdn-vzn.yottaa.net/

ksy36 commented 2 years ago

I've just discovered that this site actually has a site patch already that was added in https://github.com/webcompat/web-bugs/issues/95003. It allows the site to load. To fix this particular issue, an override needs to be added for the CDN domain that Karl mentioned

webcompat-bot commented 2 years ago

Generate outreach template

miketaylr commented 2 years ago

https://cdn-vzn.yottaa.net/

Oh this company is a 15 minute drive from my house.

miketaylr commented 2 years ago

Maybe @rockstarapps @mmaberry-yottaa @danbiagini-work could help with the Yottaa CDN issue?

miketaylr commented 2 years ago

Hm, it's somehow worse in Firefox (in 101 Nightly at least). When I disable the intervention, I get a blank page and a 403 response on the main document.

karlcow commented 2 years ago

@denschub @ksy36 we need to make sure that the CDN has the patch applied. Let's double chech it is working properly. Note to myself too.

karlcow commented 2 years ago

Capture d’écran 2022-04-08 à 11 53 17

Anything on the domain https://cdn-vzn.yottaa.net/

link to content looks like:

https://cdn-vzn.yottaa.net/5d02a70c4f1bbf63c39ca930/www.hannaandersson.com/v~4b.db/on/demandware.static/Sites-hannaandersson-Site/-/default/v1649354100558/js/lib/jquery/ui/jquery-ui.min.js?yocs=T_U_

if I do a direct access it fails indeed.

❯ http --print hH GET "https://cdn-vzn.yottaa.net/5d02a70c4f1bbf63c39ca930/www.hannaandersson.com/v~4b.db/on/demandware.static/Sites-hannaandersson-Site/-/default/v1649354100558/js/lib/jquery/ui/jquery-ui.min.js?yocs=T_U_" "User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:101.0) Gecko/20100101 Firefox/101.0"
GET /5d02a70c4f1bbf63c39ca930/www.hannaandersson.com/v~4b.db/on/demandware.static/Sites-hannaandersson-Site/-/default/v1649354100558/js/lib/jquery/ui/jquery-ui.min.js?yocs=T_U_ HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: cdn-vzn.yottaa.net
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:101.0) Gecko/20100101 Firefox/101.0
HTTP/1.1 403 Forbidden
Age: 0
Content-Length: 0
Content-Type: text/html; charset=utf-8
Date: Fri, 08 Apr 2022 02:57:19 GMT
Server: YServer
Timing-Allow-Origin: *
X-Yottaa-FW: fb/100 tid/5d02a70b4f1bbf63c39ca834 rid/5c082893312e584eb3a07e2f stid/51e78cfdf2da15e324a79046
X-Yottaa-Metrics: 3811cc023144/[-,0.341]

Then with 99

❯ http --print hH GET "https://cdn-vzn.yottaa.net/5d02a70c4f1bbf63c39ca930/www.hannaandersson.com/v~4b.db/on/demandware.static/Sites-hannaandersson-Site/-/default/v1649354100558/js/lib/jquery/ui/jquery-ui.min.js?yocs=T_U_" "User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:99.0) Gecko/20100101 Firefox/99.0"
GET /5d02a70c4f1bbf63c39ca930/www.hannaandersson.com/v~4b.db/on/demandware.static/Sites-hannaandersson-Site/-/default/v1649354100558/js/lib/jquery/ui/jquery-ui.min.js?yocs=T_U_ HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: cdn-vzn.yottaa.net
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:99.0) Gecko/20100101 Firefox/99.0
HTTP/1.1 200 OK
Age: 32602, 32602
CF-Cache-Status: HIT
CF-RAY: 6f87bdb44ab41060-ATL
Cache-Control: public, max-age=604800
Content-Encoding: gzip
Content-Length: 64467
Content-Type: application/javascript
Cross-Origin-Resource-Policy: cross-origin
Date: Fri, 08 Apr 2022 02:58:24 GMT
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Expires: Sun, 08 May 2022 02:58:24 GMT
Last-Modified: Thu, 07 Apr 2022 00:11:31 GMT
Server: cloudflare
Timing-Allow-Origin: *
X-Yottaa-ForceCache: false
X-Yottaa-Metrics: 33218cae0c78/[41,34,-] 33118cae0c64/[-,75.901]
X-Yottaa-Optimizations: ob/1000 si/33118cae0c64-1648560225-1009559827 tts/1649293027940 ti/5d02a70b4f1bbf63c39ca89d ai/5d02a70b4f1bbf63c39ca834 tm/0
vary: accept-encoding
x-dw-request-base-id: FTx7X3YlT2IBAAB_

So this is really based on UA sniffing. They need to be contacted.

karlcow commented 2 years ago

The company is https://www.yottaa.com/ They are on twitter https://twitter.com/yottaa

oh and on github too https://github.com/Yottaa

@rockstarapps is associated to the repo and might be able to help us here.

he is the CTO of @Yottaa https://www.linkedin.com/in/bbuffone/

I sent a message on linkedin too.

karlcow commented 2 years ago

I don't know if @drq is still working for @yottaa too.

denschub commented 2 years ago

@denschub @ksy36 we need to make sure that the CDN has the patch applied. Let's double chech it is working properly. Note to myself too.

The original UA cap was added in bug 1757212, so let's ping @wisniewskit too, jfyi.

I filed bug 1764795 for adding the cap to the CDN as well, and I'll ship it in 100.

karlcow commented 2 years ago

@danbiagini is working for @yottaa too. Let see if we can find people who could help us solve this for Firefox and Chrome 100. @philga7

trying to contact the CEO through linkedin. https://www.linkedin.com/in/richstendardo/

karlcow commented 2 years ago

Also called for help https://twitter.com/webcompat/status/1515848749498572801

karlcow commented 2 years ago

Contact on linkedin for the CEO was successful. He said that it has been fixed. It seems to be the case for Hanna Andersson. @miketaylr is it fixed for Chrome too. But I still have issues with Simon this morning on #102514

miketaylr commented 2 years ago

Fantastic, thanks @karlcow

karlcow commented 2 years ago

So on https://github.com/webcompat/web-bugs/issues/102514 The CTO contacted us and we might be able to remove the UA override.

denschub commented 2 years ago

The site has been fixed.