webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
739 stars 63 forks source link

www.blibli.com - Unable to set products in “List View” mode #13513

Closed softvision-oana-arbuzov closed 6 years ago

softvision-oana-arbuzov commented 6 years ago

URL: https://www.blibli.com/jual/test?s=test

Browser / Version: Firefox Mobile Nightly 59.0a1 (2017-11-14) Operating System: Huawei P10 (Android 7.0) - Resolution 1080 x 1920 pixels (~432 ppi pixel density) Tested Another Browser: Yes

Problem type: Design is broken Description: Unable to set products in “List View” mode Steps to Reproduce:

  1. Navigate https://www.blibli.com/jual/test?s=test.
  2. Tap the “View” mode button.
  3. Observe behavior.

Expected Behavior: Products are displayed according to the set “View” mode.

Actual Behavior: Nothing happens. Products remain in “Grid View” mode.

Note:

  1. Reproducible on Firefox 56.0 Release (Mobile).
  2. Not reproducible on Chrome (Mobile) 62.0.3202.84.
  3. Screenshot attached.

Watchers: @softvision-sergiulogigan @softvision-oana-arbuzov

sv; country: id

viewmodebtn_notworking

From webcompat.com with ❤️

softvision-oana-arbuzov commented 6 years ago

This issue is still reproducible.

Affected area:

<div class="block-filter-view">
    <button class="btn-grid-list">
        <i id="grid-list" class="bli bli1 bli-list"></i>
    </button>
</div>

EV click:

function() {
  isListViewActive = !isListViewActive, $(this).toggleClass("bli-view-module"), $(".product-detail-wrapper").toggleClass("listview")
}
function nrWrapper() {
  var r, a, c, s;
  try {
    a = this, r = i(arguments), c = "function" == typeof n ? n(r, a) : n || {}
  } catch (f) {
    p([f, "", [r, a, o], c])
  }
  u(e + "start", [r, a, o], c);
  try {
    return s = t.apply(a, r)
  } catch (d) {
    throw u(e + "err", [r, a, d], c), d
  } finally {
    u(e + "end", [r, a, s], c)
  }
}

Tested with: Browser / Version: Firefox Nightly Mobile 60.0a1 (2018-02-15) Operating System: Google Pixel (Android 8.1.0) - Resolution 1080 x 1920 pixels (~441 ppi pixel density), Samsung Galaxy S7 Edge (Android 7.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)

karlcow commented 6 years ago

This relies on window.event. To fix it they need to pass the event in the function.

karlcow commented 6 years ago

Close as duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=218415

miketaylr commented 6 years ago

This relies on window.event. To fix it they need to pass the event in the function.

Still not working in latest Firefox Nightly. @karlcow, want to look again?

karlcow commented 6 years ago

Ah…

Screenshot Description

maybe… could it be target?

If I move the id='grid-list'on button and in the console I re-enter

$('#grid-list').click(function () {
isListViewActive = !isListViewActive,
$(this).toggleClass('bli-view-module'),
$('.product-detail-wrapper').toggleClass('listview')
})

The button is working and changes the view.

karlcow commented 6 years ago

Close as duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1089326