webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
743 stars 66 forks source link

github.com - Github sends apk with with wrong mimetype #340

Closed wesj closed 10 years ago

wesj commented 10 years ago

URL: https://github.com/mozilla/MozStumbler/releases Browser / Version: Firefox 35.0 Operating System: Android Problem type: Looks like the website has a bug. Site owner: No

Steps to Reproduce 1) Go to https://github.com/mozilla/MozStumbler/releases in Firefox Android nightly 2) Download the apk. Look at the mimetype sent with the download 3) Launch Android's download manager and try to launch the file

Expected Behavior: Should be "application/vnd.android.package-archive" Actual Behavior: Get "application/octet-stream"

We'd like to send the mimetype sent by the site to the download manager on Android, but if sites send blatantly wrong ones, we'll probably have to fall back to guessing on our own like Chrome does.

miketaylr commented 10 years ago

I sent an email to support@github.com.

miketaylr commented 10 years ago

I got a response back from GitHub that they fixed this.

curl -I https://github.com/mozilla/MozStumbler/releases/download/v0.40.0.0/MozStumbler-v0.40.0.0.apk
HTTP/1.1 302 Found
Server: GitHub.com
Date: Thu, 09 Oct 2014 15:07:39 GMT
Content-Type: text/html; charset=utf-8
Status: 302 Found
X-XSS-Protection: 1; mode=block
X-Frame-Options: deny
Content-Security-Policy: default-src *; script-src assets-cdn.github.com www.google-analytics.com collector-cdn.github.com; object-src assets-cdn.github.com; style-src 'self' 'unsafe-inline' 'unsafe-eval' assets-cdn.github.com; img-src 'self' data: assets-cdn.github.com identicons.github.com www.google-analytics.com collector.githubapp.com *.githubusercontent.com *.gravatar.com *.wp.com; media-src 'none'; frame-src 'self' render.githubusercontent.com gist.github.com www.youtube.com player.vimeo.com checkout.paypal.com; font-src assets-cdn.github.com; connect-src 'self' ghconduit.com:25035 live.github.com uploads.github.com s3.amazonaws.com
Vary: X-PJAX
Location: https://s3.amazonaws.com/github-cloud/releases/11164718/33a5ed70-4e5d-11e4-9723-08b99085614c.apk?response-content-disposition=attachment%3B%20filename%3DMozStumbler-v0.40.0.0.apk&response-content-type=application/vnd.android.package-archive&AWSAccessKeyId=AKIAISTNZFOVBIJMK3TQ&Expires=1412867319&Signature=i4XE5%2B%2BN8R3p%2BZiYEGHt13PmE%2BY%3D
Cache-Control: no-cache
X-UA-Compatible: IE=Edge,chrome=1
Set-Cookie: logged_in=no; domain=.github.com; path=/; expires=Mon, 09-Oct-2034 15:07:39 GMT; secure; HttpOnly
Set-Cookie: _gh_sess=eyJzZXNzaW9uX2lkIjoiOTYxYTg2ZWQ1MzdhMDkwMWUyM2ExNjJhZDFhM2ZhMTQiLCJzcHlfcmVwbyI6Im1vemlsbGEvTW96U3R1bWJsZXIiLCJzcHlfcmVwb19hdCI6MTQxMjg2NzI1OX0%3D--43aede900d812fdf7e8630e340c0d3f892585d1f; path=/; secure; HttpOnly
X-Runtime: 0.034173
X-GitHub-Request-Id: 42D2B406:2C57:428D0E:5436A4B5
Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
X-Content-Type-Options: nosniff
Vary: Accept-Encoding
X-Served-By: a22dbcbd09a98eacdd14ac7804a635dd

&response-content-type=application/vnd.android.package-archive from the Location header looks good to me. Can you verify @wesj?

miketaylr commented 10 years ago

Actually, I'm near an Android phone now. Fixed, thanks @github!