search

webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
747 stars 67 forks source link

m.futureshop.ca - site is entirely hosed under our mobile UA #663

Closed AaronMT closed 9 years ago

AaronMT commented 9 years ago

URL: http://m.futureshop.ca/?lang=en Browser / Version: Firefox Mobile 38.0 Operating System: Android Problem type: Looks like the website has a bug. Site owner: No

Steps to Reproduce 1) Navigate to: http://m.futureshop.ca/?lang=en 2) …

Expected Behavior: a working site Actual Behavior: site is hosed, nothing is displayed

miketaylr commented 9 years ago

Hmm, weird. It's blank in Firefox desktop as well--no matter what UA string I use. Need to dig in.

miketaylr commented 9 years ago

In bootstrap.css:

body {
    display: none;
    font-size: 12px;
}

And in Chrome you can see there's an inline style which overrides that: <body style="display: block;">

miketaylr commented 9 years ago

Looking in script.min.js, in e.init() you can see where they call $('body').show()

$(document).ready(function() {
  var e = new mwa();
  ...
  e.init({setupAjaxPages: h.ajaxPages,onAppStart: function() {
      $("body").show();
      f.loadingAnimation();
      util.eraseCookie("bbyca_mob_optout_fs")
    }});
  ...
});

mwa.onAppStart is firing correctly--but for some reason $("body").show() doesn't do what I expect (even in the console). Running $("body").css("display", "block") gets the page to render. Still looking...

miketaylr commented 9 years ago

Ah, OK. So it turns out this was a bug in jQuery that was fixed in 1.8.3. This site is using 1.7.1.

You can read up on http://bugs.jquery.com/ticket/10227 for more details, or https://bugzilla.mozilla.org/show_bug.cgi?id=797029 for even more details for the interested.

The suggested fix would be to update to jQuery >= 1.8.3, OR to change $("body").show(); to $("body").css("display", "block");

miketaylr commented 9 years ago

I pointed them at this bug: https://twitter.com/miketaylr/status/560927278360559616

karlcow commented 9 years ago

duplicate of #626 and #610

miketaylr commented 9 years ago

Thanks @karlcow -- had missed those.

miketaylr commented 9 years ago

They replied that they passed it along to their developers: https://twitter.com/FutureShop/status/560933304267182081

We've passed that along. Thanks! :)

sagrid commented 9 years ago

Futureshop.ca URL feels OK, what's the problem?

karlcow commented 9 years ago

@sagrid which mobile device are you using?

miketaylr commented 9 years ago

Still blank for me in Firefox for Android.

miketaylr commented 9 years ago

m.futureshop.ca now redirects to m.bestbuy.ca (which still is blank, but they're working on it).