webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
748 stars 68 forks source link

www.bilibili.com - Missing enable "Live comments" option #67472

Open softvision-raul-bucata opened 3 years ago

softvision-raul-bucata commented 3 years ago

URL: https://www.bilibili.com/video/av886845847

Browser / Version: Firefox Nightly 88.01a Operating System: Windows 10 Tested Another Browser: Yes Chrome

Problem type: Something else Description: Missing enable "Live comments" option Steps to Reproduce:

  1. Navigate to https://www.bilibili.com/video/av886845847 .
  2. Locate the Configuration menu with the "Settings" gear icon under the video.
  3. Hover the mouse over it.
  4. Observe the checkboxes that are being displayed.

Expected results: 3 checkboxes are displayed

Actual result: "智能防挡弹幕" checkbox is missing

Notes:

  1. Does not reproduce in Chrome
  2. Setting Chrome User Agent the option is displayed.
View the screenshot Firefox Nightly: Screenshot Chrome: ![Screenshot_16](https://user-images.githubusercontent.com/75027050/108868253-b1cbd280-75fe-11eb-8cbc-25c1d5604f04.jpg)
Browser Configuration
  • None

From webcompat.com with ❤️

karlcow commented 3 years ago

So this is what I get on Firefox Nightly 88.0a1 (2021-03-15) (64-bit) on macos

Capture d’écran 2021-03-17 à 11 31 40

So I don't get the same exact menu. It seems to vary depending on the platform.

The missing option is Intelligent anti-block barrage?

I can't really reproduce, but I'm not on windows either.

@ksy36 do you reproduce on macOS? @softvision-oana-arbuzov on windows?

softvision-oana-arbuzov commented 3 years ago

@karlcow I can still reproduce the issue on Windows. image

Tested with: Browser / Version: Firefox Nightly 88.0a1 (2021-03-16) Operating System: Windows 10 Pro

karlcow commented 3 years ago

This is done here.

        this.player.userLoadedCallback((function (r) {
          r.mask_new && 'chrome' === u.browser.version.browser && !u.browser.version.edge && i.player.config.hasDanmaku ? (t.find('.' + a + '-video-danmaku-setting-left-danmaku-mask').show(), i.maskDanmaku = new ri.b(t.find('.' + a + '-video-danmaku-setting-left-danmaku-mask-box') [0], {
            name: '智能防挡弹幕',
            value: e.controller.config.setting_config.dmask,
            dark: !0
          }), i.maskDanmaku.on('change', (function (e) {
            var t,
            a;
            i.player && e.manual && (null === (t = i.player.track) || void 0 === t || t.trackInfoPush('ctlbar_danmuku_dmask'), i.getMask(e.value, r.mask_new)),
            null === (a = i.danmakuMask) || void 0 === a || a.setting('dmask', e.value),
            i.player.set('setting_config', 'dmask', e.value),
            i.currentSet.dmask = e.value
          })), i.setMask(r.mask_new)) : t.find('.' + a + '-video-danmaku-setting-left-danmaku-mask').hide()
        })),

That said I'm not sure why they did this

"'chrome' === u.browser.version.browser && !u.browser.version.edge"

because when I fake the UA I don't see a difference, nor error message in the console.

Let's move to needscontact.

webcompat-bot commented 3 years ago

Generate outreach template

karlcow commented 3 years ago

Maybe we could do a sitepatch, but I'm not sure what it would solve.

denschub commented 2 years ago

it looks like they have a different menu now. The options are, if I'm not mistaken, now displayed in a different manner:

Screenshot 2021-11-30 at 17 47 07

The available options appear to be the same in Chrome and Firefox.

softvision-oana-arbuzov commented 2 years ago

@denschub they just moved the menu under the video and the issue is still reproducible. Firefox: image

Chrome: image

Tested with: Browser / Version: Firefox Nightly 96.0a1 (2021-12-04) Operating System: Windows 10 Pro

Reopening and moving back to Needscontact.

webcompat-bot commented 2 years ago

Generate outreach template

denschub commented 2 years ago

Thanks for checking! Then, as Karl said earlier, this is in need of a contact. It's pretty hard for us to understand what's going on here. :) We can leave this in needscontact for now.