webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
747 stars 67 forks source link

www.olx.in - Some icons are truncated at the bottom #7665

Closed softvision-sergiulogigan closed 5 years ago

softvision-sergiulogigan commented 7 years ago

URL: www.olx.in Browser / Version: Firefox Mobile Nightly 56.0a1 (2017-06-21) Operating System: Samsung Galaxy S6 (Android 7.0) - 1440 x 2560 pixels (~577 ppi pixel density) Problem type: Something else - I'll add details below

Steps to Reproduce

  1. Navigate to: www.olx.in. Observe the section icons.

Expected Behavior: All icons are round.

Actual Behavior: Some icons are truncated at the bottom.

Notes:

  1. The issue is also reproducible on Firefox 54.0 Release (Mobile).
  2. The issue is not reproducible on Chrome (Mobile) 58.0.3029.83.
  3. Screenshot attached.

Watchers: @softvision-oana-arbuzov @softvision-sergiulogigan

sv; country: in

Screenshot Description

From webcompat.com with ❤️

softvision-sergiulogigan commented 7 years ago

It looks like this issue is reproducible across the whole website... screenshot

karlcow commented 7 years ago
<a href="#" class="abs listStarbutton  binded">
    <span class="block icon starflat2 listStar"></span>
</a>

This is using a bakcground-image with sprites.

.icon {
    background: url(https://s1.olx.in/static/olxin/packed/img/2fe7a067d26bc75720acc810cbed38fa9f.png) no-repeat;
}

.icon {
    background-image: url(https://s2.olx.in/static/olxin/packed/img/2fce8cc8b9aec92d91391cec19048aeae2.png);
    background-size: 300px 608px;
}

.icon.starflat2 {
    width: 21px;
    height: 20px;
    background-position: -96px -241px;
}

Probably needs to contact them.

karlcow commented 7 years ago

@szymanskilukasz could you help us find the right people at OLX to fix this issue? Thanks.

szymanskilukasz commented 7 years ago

@karlcow Wow cool project :) Didn't know it before. I will send this thread to my colleagues in OLX IN :)

karlcow commented 7 years ago

Thanks a lot. Appreciated!

cipriansv commented 5 years ago

After retesting the issue I noticed that the layout has changed.

image

Tested with: Browser / Version: Firefox Nightly 68.1a1 (2019-08-13), Firefox Preview 1.2.0 (Build #12181645) Operating System: Huawei P10 (Android 8.0) - 1080 x 1920 pixels (~432 ppi pixel density)

Closing as invalid.