webcompat / web-bugs

A place to report bugs on websites.
https://webcompat.com
Mozilla Public License 2.0
742 stars 65 forks source link

m.urlaub.check24.de - Missing radio buttons for the “Filter” options #9923

Closed softvision-oana-arbuzov closed 4 years ago

softvision-oana-arbuzov commented 7 years ago

URL: https://m.urlaub.check24.de/suche/hotel/informationen?airport=BRE,CGN,CSO,DRS,DTM,DUS,ERF,FDH,FKB,FMM,FMO,FRA,GWT,HAJ,HAM,HHN,KSF,LBC,LEJ,MUC,NRN,NUE,PAD,RLG,SCN,STR,SXF,TXL&adult=2&departureDate=2017-08-29&returnDate=2017-10-24&travelDuration=1w&hotelCategory=2&hotelCategoryList=2,3,4,5&hotelCategoryMax=5&cateringList=allinclusive&roomType=villa&page=1&pageArea=package&oceanView=1&regionId=603&rating=4.3&recommendation=-&sorting=categoryDistribution&order=asc&offerSort=price&offerSortOrder=asc&regionSort=topregion&regionSortOrder=asc&hotelOnly=1&extendedSearch=1&beach=1&sur=1&hotelId=4151

Browser / Version: Firefox Mobile Nightly 57.0a1 (2017-09-13) Operating System: Nexus 5 (Android 6.0.1) - Resolution 1080 x 1920 pixels (~445 ppi pixel density) Tested Another Browser: Yes

Problem type: Design is broken Description: Missing radio buttons for the “Filter” options
Steps to Reproduce:

  1. Navigate to: https://m.urlaub.check24.de/suche/hotel/informationen?airport=BRE,CGN,CSO,DRS,DTM,DUS,ERF,FDH,FKB,FMM,FMO,FRA,GWT,HAJ,HAM,HHN,KSF,LBC,LEJ,MUC,NRN,NUE,PAD,RLG,SCN,STR,SXF,TXL&adult=2&departureDate=2017-08-29&returnDate=2017-10-24&travelDuration=1w&hotelCategory=2&hotelCategoryList=2,3,4,5&hotelCategoryMax=5&cateringList=allinclusive&roomType=villa&page=1&pageArea=package&oceanView=1&regionId=603&rating=4.3&recommendation=-&sorting=categoryDistribution&order=asc&offerSort=price&offerSortOrder=asc&regionSort=topregion&regionSortOrder=asc&hotelOnly=1&extendedSearch=1&beach=1&sur=1&hotelId=4151.
  2. Tap the “75 Gästebewertungen” (“Guest Reviews”) tab.
  3. Tap the “Filtern” (“Filter”) button.
  4. Observe overlay.

Expected Behavior: Radio buttons are displayed for the “Filter” options.

Actual Behavior: Radio buttons are missing for the “Filter” options.

Note:

  1. Tapping one of the options, the radio buttons become available when accessing the overlay again.
  2. Reproducible on Firefox 55.0.2 Release (Mobile)
  3. Not reproducible on Chrome (Mobile) 60.0.3112.107.
  4. Screenshot attached.

Watchers: @softvision-sergiulogigan @softvision-oana-arbuzov

sv; country: de Screenshot Description

From webcompat.com with ❤️

miketaylr commented 7 years ago

Possibly https://bugzilla.mozilla.org/show_bug.cgi?id=1399776?

softvision-oana-arbuzov commented 6 years ago

The issue is still reproducible. noradiobtn_filtermenu

Note that the layout has changed a bit. screenshot-1517325711130

Tested with: Browser / Version: Firefox Nightly Mobile 60.0a1 (2018-01-29) Operating System: Google Pixel (Android 8.1.0) - Resolution 1080 x 1920 pixels (~441 ppi pixel density)

adamopenweb commented 6 years ago

As mentioned in #9147, reaching out to info@check24.de for multiple bug reports.

karlcow commented 6 years ago

Switching to sitewait according to @adamopenweb comment.

karlcow commented 6 years ago

And the design has changed again :)

Screenshot Description

At least one issue with the input element. There is a missing -moz-appearance: none

select.rating-mobile-filter {
    width: 46%;
    padding: 8px;
    color: #005ea8;
    font-size: 15px;
    background: url('//m.urlaub.check24.de/v3.32.54/img/portal/default/latest/form_elements/select-arrows.png') no-repeat right -36px #ebebeb;
    border: none;
}

so that we can have only one arrow. After adding it:

Screenshot Description

But on the Alle Bewertungen button if I tap I get the right behavior in Firefox Android Nightly.

Closing as worksforme ? @softvision-oana-arbuzov

softvision-oana-arbuzov commented 6 years ago

I have the 2 designs on different phones and I'm able to reproduce the issue on one of them. screenshot_1

Tested with: Browser / Version: Firefox Mobile Nightly 61.0a1 (2018-03-19) Operating System: Google Pixel (Android 8.0.0) - 1080 x 1920 pixels (~441 ppi pixel density), Samsung Galaxy S7 Edge (Android 7.0) - 1440 x 2560 pixels (~534 ppi pixel density)

softvision-oana-arbuzov commented 5 years ago

The issue is still reproducible on my side. URL: https://urlaub.check24.de/vergleiche/11616-1-1-0/GriechischeInseln/Griechenland/Kreta/AgiosNikolaos%28InselKreta%29/Urlaub+Minos%20Beach%20Art

MissingRadioBtns

Note: Not reproducible on Fenix 1.0.1925 (Build #11691815 🦎 68.0-201906011143747)

Tested with: Browser / Version: Firefox Nightly 68.0a1 (2019-06-18), Operating System: LG G5 (Android 8.0.0) - 1440 x 2560 pixels (~554 ppi pixel density),Samsung Galaxy S7 Edge (Android 8.0.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)

softvision-oana-arbuzov commented 4 years ago

Thanks issue is still reproducible on Firefox Nightly 68.3a1 (2019-11-02) , but seems to be fixed on Firefox Preview Nightly 191104 (🦎: 72.0a1-20191101093621) image

Tested with: Operating System: Huawei P20 Lite (Android 8.0.0) - 1080 x 2280 pixels, 19:9 ratio (~432 ppi density), Samsung Galaxy S7 Edge (Android 8.0.0) - Resolution 1440 x 2560 pixels (~534 ppi pixel density)

@karlcow should we close this since it is no longer reproducible on Firefox Preview Nightly ?

karlcow commented 4 years ago

yes :)