search

webcompat / webcompat-metrics-server

Server in charge of delivering different data to the webcompat-metrics-client
Mozilla Public License 2.0
6 stars 5 forks source link

Contactready status is missing from the dashboard #126

Closed karlcow closed 5 years ago

karlcow commented 5 years ago

@magsout @laghee did you notice we never added the contactready graph. I'm not sure why? Maybe we just forgot.

laghee commented 5 years ago

@karlcow Huh. Maybe we did forget? 🤔

I do have a vague memory about a discussion early on -- whether needscontact and contactready should be merged because how often did it happen that someone dug out a contact address but didn't actually go on to make the contact -- but I don't think it was ever answered decisively. Judging from a couple of the most recent bugs, contactready gets used often when it's an entity we've dealt with before or with whom we have an existing relationship. So certainly makes sense to keep it.

karlcow commented 5 years ago

ok. That makes sense. Let's add it, now we are tracking this a bit more closely. Thanks a lot @laghee for the context.

karlcow commented 5 years ago

We need to add the route. https://webcompat-metrics.herokuapp.com/data/contactready-timeline?from=2019-09-14&to=2019-10-14

https://github.com/webcompat/webcompat-metrics-server/blob/d90b67ec726461e717c60690acb2a9305cc10efa/ochazuke/api/views.py#L54-L83

which probably means adding it to the list of valid categories.

https://github.com/webcompat/webcompat-metrics-server/blob/d90b67ec726461e717c60690acb2a9305cc10efa/ochazuke/helpers.py#L82-L88

should be an easy fix on the server side, we probably already collect the data?

laghee commented 5 years ago

@karlcow We actually were not already collecting the data 😊, but as of this evening (UTC) we are.
Screenshot 2019-10-28 20 03 03

Won't be a pretty graph for a while, but at least this isn't a data point that probably changes all that dramatically.

laghee commented 5 years ago

Since the route is actually a template that works for all the hourly counted milestones, looks like we indeed only need to add contactready to the list of valid categories as mentioned above. Easy fix on this end!