webcompat / webcompat-metrics-server

Server in charge of delivering different data to the webcompat-metrics-client
Mozilla Public License 2.0
6 stars 5 forks source link

firefox-interventions response #136

Open magsout opened 4 years ago

magsout commented 4 years ago

@denschub is it possible to send an error when client doesn't send all filters required? Right now, the api send an empty response.

magsout commented 4 years ago

for example https://webcompat-metrics.herokuapp.com/data/firefox-interventions?end=2020-06-09&start=2020-01-01

denschub commented 4 years ago

Sure, I could do that. For the moment, it looks like no endpoint is doing any kind of error handling, as https://webcompat-metrics.herokuapp.com/data/needstriage-timeline?from=2020-05-09 for example just 404s, but if you'd prefer that, I don't see a reason not to throw some error. I don't know if there is some kind of design decision behind not really doing error handling, or if this is just "nobody did it yet", so I'll leave this decision to someone else. Happy to implement it, though, if we need it! :)