webcompat / webcompat-metrics-server

Server in charge of delivering different data to the webcompat-metrics-client
Mozilla Public License 2.0
6 stars 5 forks source link

Fixes #95 - Add JSON templates to db test response #96

Closed laghee closed 5 years ago

laghee commented 5 years ago

Aha! I knew I was missing something...

magsout commented 5 years ago

👍

laghee commented 5 years ago

Thanks, @magsout!

Hmm. Something's wrong. I'm getting a JSON parse error: Screenshot 2019-03-17 21 50 09 Screenshot 2019-03-17 21 50 17

Am I doing something weird when I form the object structure?

laghee commented 5 years ago

Aha! Thanks, @karlcow! Change made -- endpoint now works with client side requests: Screenshot 2019-03-20 17 30 22

Do you still think we need a default no-date-range response even if the client side is configured to supply a default range? (See my question in the metrics-client issue: https://github.com/webcompat/webcompat-metrics-client/issues/145#issuecomment-474917283)

karlcow commented 5 years ago

Thanks @laghee This is wonderful.